Skip to content

Migrate <Switch> to PF4 #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 17, 2019
Merged

Migrate <Switch> to PF4 #2708

openshift-merge-robot merged 1 commit into from
Sep 17, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 12, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM labels Sep 12, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 12, 2019

/hold
for 4.3

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2019
@rhamilto rhamilto added this to the v4.3 milestone Sep 12, 2019
spadgett
spadgett approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

frontend/public/vendor.scss Outdated
Copy link
Member

@spadgett spadgett Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I confirmed kubevirt-web-ui-components doesn't reference Switch so this should be safe

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 13, 2019

/retest

2 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Sep 13, 2019

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Sep 13, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Sep 13, 2019

@rhamilto the test failure here looks like it might be caused by the change

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2019
@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 13:10
spadgett
spadgett approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 01c832d into openshift:master-4.3 Sep 17, 2019
@rhamilto rhamilto deleted the pf4-switch branch September 17, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@josephschorr josephschorr Awaiting requested review from josephschorr

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @spadgett @openshift-ci-robot @openshift-merge-robot